Skip to content

[ci] do not rebuild base or base-build in PR runs#1008

Open
fdupress wants to merge 1 commit into
docker-consolidatefrom
ci-retrieve-base
Open

[ci] do not rebuild base or base-build in PR runs#1008
fdupress wants to merge 1 commit into
docker-consolidatefrom
ci-retrieve-base

Conversation

@fdupress
Copy link
Copy Markdown
Member

Streamline the docker builds slightly

  • Use the last base box from main for PR and merge queue runs. Rebuild
    only on pushes to main and releases.
  • Reuses the already-built build box when building the test box.

Merge after #1007 .

@fdupress fdupress force-pushed the ci-retrieve-base branch from 01c09e2 to 69d119c Compare May 14, 2026 18:07
@fdupress fdupress self-assigned this May 14, 2026
@fdupress fdupress added the chore Ungrateful tasks that need done but that nobody wants to do label May 14, 2026
@fdupress fdupress force-pushed the ci-retrieve-base branch from 69d119c to b23cae8 Compare May 15, 2026 18:07
@fdupress fdupress changed the base branch from main to docker-consolidate May 15, 2026 18:07
@fdupress fdupress force-pushed the docker-consolidate branch from a26cd8b to 7019e6d Compare May 18, 2026 15:06
@fdupress fdupress force-pushed the ci-retrieve-base branch from b23cae8 to 8e3645d Compare May 18, 2026 15:07
@fdupress fdupress force-pushed the ci-retrieve-base branch from 8e3645d to b2e1f4f Compare May 18, 2026 18:13
@fdupress fdupress changed the title [ci] do not rebuild base in PR runs [ci] do not rebuild base or base-build in PR runs May 18, 2026
@fdupress fdupress force-pushed the ci-retrieve-base branch 2 times, most recently from f731763 to 25e2511 Compare May 18, 2026 19:07
Streamline the docker builds slightly
- Use the last base-build box from `main` for PR and merge queue runs.
  Rebuild only on pushes to `main` and releases.
- Push the base-build box on `main` and releases CI runs.
- Reuse the already-built build box when building the test box.
@fdupress fdupress force-pushed the ci-retrieve-base branch from 25e2511 to 41e3e92 Compare May 18, 2026 19:26
@fdupress fdupress marked this pull request as ready for review May 18, 2026 19:53
@fdupress fdupress requested a review from strub May 18, 2026 19:54
@fdupress
Copy link
Copy Markdown
Member Author

The performance bump here justifies (I think) the refactor in #1007. This makes the docker build essentially free on PRs.

Worth questioning whether we want this also on main (so we would not be updating the environment except on release). The installation of EasyCrypt dependencies in the test target, which is not short-circuited, would still update and install system dependencies as needed for CI runs from main images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Ungrateful tasks that need done but that nobody wants to do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant